Add tests for bokeh #863
Merged
Add tests for bokeh #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canyon289
reviewed
Nov 12, 2019
| ], | ||
| ) | ||
| def test_plot_trace(models, kwargs): | ||
| axes = plot_trace(models.model_1, backend="bokeh", show=False, **kwargs) |
There was a problem hiding this comment.
Aw I missed chance to comment but in future tests I dont think we should test plotting at the user interface anymore. We should import the bokeh plot function and test against those. That way we're speed up tests and making tests more unit like.
This is small amount of tests so no big deal, Ill draw a picture and/or make a PR later to refactor :)
Thank you for adding!
There was a problem hiding this comment.
Yeah we can change this, I just wanted tests quickly to master and there was also small bugs, same with the current PR for rug.
Let's clean these after initial implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bokeh tests and general fixes for bokeh.