Make rcparams more robust and explicit #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also increases testing of rcparams
ColCarroll
approved these changes
Nov 22, 2019
arviz/tests/test_rcparams.py
Outdated
| def test_warning_rc_file(caplog): | ||
| """Test invalid lines and duplicated keys log warnings and bad value raises error.""" | ||
| path = os.path.dirname(os.path.abspath(__file__)) | ||
| read_rcfile(path + "/test.rcparams") |
There was a problem hiding this comment.
Suggested change
| read_rcfile(path + "/test.rcparams") | |
| read_rcfile(os.path.join(path, "/test.rcparams")) |
windows uses \ as a separator, so we have to play this game, or use pathlib.
There was a problem hiding this comment.
Should the / in "/test.rcparams" be removed?
Co-Authored-By: Colin <ColCarroll@users.noreply.github.com>
arviz/tests/test_rcparams.py
Outdated
| @@ -91,7 +91,7 @@ def test_rcparams_repr_str(): | |||
| """Check both repr and str print all keys.""" | |||
| repr_str = rcParams.__repr__() | |||
| str_str = rcParams.__str__() | |||
| assert repr_str[:8] == "RcParams" | |||
| assert repr_str.startsWith("RcParams") | |||
|
This LGTM |
ahartikainen
approved these changes
Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also increases testing of rcparams