Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update roulette plot and gif #322

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Conversation

rohanbabbar04
Copy link
Contributor

@rohanbabbar04 rohanbabbar04 commented Feb 18, 2024

Description

Checklist

  • Update the gif for interactive roulette function
  • Widget states have been properly saved (only for notebooks with widgets) see for details.

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0e8364) 83.30% compared to head (3ad6bcd) 83.31%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #322   +/-   ##
=======================================
  Coverage   83.30%   83.31%           
=======================================
  Files          36       36           
  Lines        4248     4244    -4     
=======================================
- Hits         3539     3536    -3     
+ Misses        709      708    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohanbabbar04 rohanbabbar04 changed the title Update roulette.gif Update roulette.gif and plot Feb 18, 2024
@rohanbabbar04 rohanbabbar04 changed the title Update roulette.gif and plot Update roulette plot and gif Feb 18, 2024
@rohanbabbar04
Copy link
Contributor Author

I think the current ipywidgets look good and fulfills the functionality of the roulette plot.
What do you think?
We can maybe close the issue, and if required we can reopen/create a more specific issue in the future...

@aloctavodia aloctavodia merged commit c82028a into arviz-devs:main Feb 18, 2024
4 checks passed
@rohanbabbar04 rohanbabbar04 deleted the roulette_gif branch February 18, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants