Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ppa widgets to include references #328

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

rohanbabbar04
Copy link
Contributor

@rohanbabbar04 rohanbabbar04 commented Feb 21, 2024

fixes #128

Description

  • Updated ppa widgets to include references
  • Updated ppa.gif

Checklist

  • Code style is correct (follows pylint and black guidelines)
  • Widget states have been properly saved (only for notebooks with widgets) see for details.

@aloctavodia
Copy link
Contributor

can you add a picture or gif?

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c82028a) 83.31% compared to head (7e051bc) 84.07%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   83.31%   84.07%   +0.75%     
==========================================
  Files          36       37       +1     
  Lines        4244     4264      +20     
==========================================
+ Hits         3536     3585      +49     
+ Misses        708      679      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohanbabbar04
Copy link
Contributor Author

The references can take int, float, tuple or values in csv format

@aloctavodia
Copy link
Contributor

aloctavodia commented Feb 22, 2024

Alll functions that use references values accept, int float, tuple, list and dictionaries. Can we pass dictionaries with the text box? The keys are used as labels.

@rohanbabbar04
Copy link
Contributor Author

rohanbabbar04 commented Feb 22, 2024

Seems to work

image

It is not updated here for ppa(dictionary), we should do that as well

references : int, float, list or tuple
        Value(s) used as reference points representing prior knowledge. For example expected
        values or values that are considered extreme.

Should I update the docs in this PR itself?

@aloctavodia
Copy link
Contributor

Great. Yes, the docstring is outdated.

@rohanbabbar04
Copy link
Contributor Author

Great. Yes, the docstring is outdated.

Done, updated the docstring.

@aloctavodia aloctavodia merged commit 950e2a7 into arviz-devs:main Feb 22, 2024
4 checks passed
@rohanbabbar04 rohanbabbar04 deleted the ppa_interactive branch February 22, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve ipywidgets layout for ppa
3 participants