Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plot_interactive to Dirichlet #332

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

rohanbabbar04
Copy link
Contributor

@rohanbabbar04 rohanbabbar04 commented Feb 27, 2024

Issue #225

Description

  • Added xy_lim to plot_dirichlet
  • Added plot_interactive to Dirichlet where xy_lim defines x and y for each subplot.
  • Added test_plot_interactive_dirichlet for the tests.
  • Added marginals checkbox when kind=pdf (for other representations checkbox is not present)

Checklist

  • Code style is correct (follows pylint and black guidelines)
  • Includes new or updated tests to cover the new feature
  • New features are properly documented (with an example if appropriate)
  • Widget states have been properly saved (only for notebooks with widgets) see for details.

A pic for pdf
image

@aloctavodia
Copy link
Contributor

nitpick: When referencing and issue from a PR use one of these words https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword then when the PR get merged the issue will be automatically closed

@rohanbabbar04
Copy link
Contributor Author

nitpick: When referencing and issue from a PR use one of these words https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword then when the PR get merged the issue will be automatically closed

The issue actually has 2 parts
The first one is Dirichlet the next one is MVNormal
So I just needed to mention the issue and not close it...

@aloctavodia aloctavodia merged commit 9169807 into arviz-devs:main Feb 27, 2024
4 checks passed
@rohanbabbar04 rohanbabbar04 deleted the dirichlet_interactive branch February 27, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants