Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eficient hypergeometric #407

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

aloctavodia
Copy link
Contributor

This adds hypergeometric distribution. Both the cdf and ppf are computed numerically. The ppf is off by one, not sure why as all other tests are passing. In the meantime, I am handling the hypergeometric as a special case.

This also updates the find_ppf function to make it work with discrete distributions.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.86992% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 81.33%. Comparing base (f659f65) to head (e949e27).
Report is 11 commits behind head on main.

Files Patch % Lines
preliz/distributions/hypergeometric.py 88.76% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   81.14%   81.33%   +0.19%     
==========================================
  Files          73       85      +12     
  Lines        6448     7066     +618     
==========================================
+ Hits         5232     5747     +515     
- Misses       1216     1319     +103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aloctavodia aloctavodia merged commit 704b307 into arviz-devs:main Apr 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants