Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add faster Half Cauchy #409

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Add faster Half Cauchy #409

merged 3 commits into from
Apr 19, 2024

Conversation

rohanbabbar04
Copy link
Contributor

Description

  • Add HalfCauchy with all methods.
  • Add test in test_scipy.py.
  • Add HalfCauchy to docs.

Checklist

  • Code style is correct (follows pylint and black guidelines)
  • Includes new or updated tests to cover the new feature
  • New features are properly documented (with an example if appropriate)

@rohanbabbar04
Copy link
Contributor Author

rohanbabbar04 commented Apr 19, 2024 •
edited

The tests will fail there is an if statement, lemme replace it with cdf_bounds

@aloctavodia
Copy link
Contributor

Thanks, I read it very quickly and I missed the if statement! thanks for fixing it.

@aloctavodia aloctavodia merged commit aa13a08 into arviz-devs:main Apr 19, 2024
4 checks passed
@rohanbabbar04 rohanbabbar04 deleted the halfcauchy branch April 19, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloctavodia aloctavodia aloctavodia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohanbabbar04 @aloctavodia