Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add faster Truncated Normal #414

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Add faster Truncated Normal #414

merged 2 commits into from
Apr 22, 2024

Conversation

rohanbabbar04
Copy link
Contributor

Description

  • Add TruncatedNormal with all methods.
  • Add test in test_scipy.py.
  • Add TruncatedNormal to docs.

Don't really know why the test_mle in preliz/tests/test_distributions.py is failing, changing it to (-np.inf,np.inf) seems to work...

Checklist

  • Code style is correct (follows pylint and black guidelines)
  • Includes new or updated tests to cover the new feature
  • New features are properly documented (with an example if appropriate)

@aloctavodia
Copy link
Contributor

What is the error you are getting for test_mle?

@aloctavodia aloctavodia merged commit 166f362 into arviz-devs:main Apr 22, 2024
4 checks passed
@rohanbabbar04 rohanbabbar04 deleted the truncnormal branch April 22, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloctavodia aloctavodia aloctavodia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohanbabbar04 @aloctavodia