[5/7] feat(submit:phabricator): do not abort entire process on failure #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arxanas
changed the title
arxanas
force-pushed
the
arxanas/phabricator
branch
from
da5e8f5
to
70ae23b
Compare
This was referenced Jun 30, 2024
arxanas
changed the title
arxanas
changed the base branch from
master
to
arxanas/feat-submit-phabricator-pass-allow-untracked-to-arc
Base automatically changed from
arxanas/feat-submit-phabricator-pass-allow-untracked-to-arc
to
master
July 2, 2024 14:47
arxanas
force-pushed
the
arxanas/phabricator
branch
from
70ae23b
to
8c36f0b
Compare
It seems easier for contributors to get started if the compiler version is already configured; plus, this will presumably make it so that I don't have to set the Rust version with `rustup override` whenever I create a new worktree.
This should have been done from the beginning, since we operate on these symbols in several places for formatting. This would also help a migration away from `cursive`, since now only two modules have direct dependencies on `cursive`/`cursive_core`: - git-branchless-lib for general output formatting. - git-branchless-undo for the interactive undo UI.
Currently, `git submit` for Phabricator will abort the entire operation if any commit fails to be submitted. This means that if `arc diff` succeeds on one commit and then fails on its child, the entire operation is aborted. However, the first `arc diff` had side effects, so the user gets diffs uploaded to Phabricator that are not reflected locally. Instead, we should confirm any passing commits and abort after we get a failing commit. This commit updates the Phabricator forge to handle the error case better and not produce garbage commits on Phabricator.
arxanas
force-pushed
the
arxanas/phabricator
branch
from
8c36f0b
to
829a121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
--allow-untrackedtoarc#1353--jobs#1355cursive_core#1356PrepareWorkingDirectoryErrorreason #1357git test runworktree management #1358feat(submit:phabricator): do not abort entire process on failure
Currently,
git submitfor Phabricator will abort the entire operation if any commit fails to be submitted. This means that ifarc diffsucceeds on one commit and then fails on its child, the entire operation is aborted. However, the firstarc diffhad side effects, so the user gets diffs uploaded to Phabricator that are not reflected locally. Instead, we should confirm any passing commits and abort after we get a failing commit. This commit updates the Phabricator forge to handle the error case better and not produce garbage commits on Phabricator.