Sketch transients for HAMT-based data-structures #208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step towards the full implementation of transients for all HAMT-based data-structures:
map
andset
.In this PR we do define the interface in two modes:
map_transient
andset_transient
, which define a mutable interface (similar to the case ofvector_transient
and alike). This is required to benefit from the optimizations brought about by transients when using a tracing garbage collector.std::move(x)...
when performing an operation on an immutable map. This will incur in the same performance benefit as the former when using reference counting for garbage collection (default) and is the recommended way to benefit from it.In this PR we define and test the interface. We also include the new interface as part of the existing benchmarks for HAMT insertion. The implementation is however naive, this is, it is based on the purely immutable counterpart, an provides no performance benefit. We will explore different alternatives for optimization in subsequent PRs.
Issue #82
PING @omer-s @harryhk from Meta Inc. who is sponsoring this HAMT-transient implementation project!