Slightly modify examples

- This change was made to emphasize the switch from `lruMemoize` to `weakMapMemoize` inside `createSelector`
aryaemami59 · Jan 3, 2024 · c8263b5 · c8263b5
1 parent 531a496
commit c8263b5
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 8 deletions.
diff --git a/docs/examples/weakMapMemoize/cacheSizeSolution.ts b/docs/examples/weakMapMemoize/cacheSizeSolution.ts
@@ -1,4 +1,4 @@
-import { createSelector, weakMapMemoize } from 'reselect'
+import { createSelector } from 'reselect'
 import type { RootState } from './cacheSizeProblem'
 
 const state: RootState = {
@@ -10,16 +10,13 @@ const state: RootState = {
   ]
 }
 
+// `createSelector` uses `weakMapMemoize` by default.
 const selectItemsByCategory = createSelector(
   [
     (state: RootState) => state.items,
     (state: RootState, category: string) => category
   ],
-  (items, category) => items.filter(item => item.category === category),
-  {
-    memoize: weakMapMemoize,
-    argsMemoize: weakMapMemoize
-  }
+  (items, category) => items.filter(item => item.category === category)
 )
 
 selectItemsByCategory(state, 'Electronics') // Selector runs

diff --git a/docs/examples/weakMapMemoize/usingWithCreateSelector.ts b/docs/examples/weakMapMemoize/usingWithCreateSelector.ts
@@ -1,3 +1,4 @@
+import { shallowEqual } from 'react-redux'
 import { createSelector, weakMapMemoize } from 'reselect'
 import type { RootState } from './cacheSizeProblem'
 
@@ -18,7 +19,13 @@ const selectItemsByCategory = createSelector(
   (items, category) => items.filter(item => item.category === category),
   {
     memoize: weakMapMemoize,
-    argsMemoize: weakMapMemoize
+    argsMemoize: weakMapMemoize,
+    argsMemoizeOptions: {
+      resultEqualityCheck: shallowEqual
+    },
+    memoizeOptions: {
+      resultEqualityCheck: shallowEqual
+    }
   }
 )
 

diff --git a/docs/examples/weakMapMemoize/usingWithCreateSelectorCreator.ts b/docs/examples/weakMapMemoize/usingWithCreateSelectorCreator.ts
@@ -1,3 +1,4 @@
+import { shallowEqual } from 'react-redux'
 import { createSelectorCreator, weakMapMemoize } from 'reselect'
 import type { RootState } from './cacheSizeProblem'
 
@@ -12,7 +13,13 @@ const state: RootState = {
 
 const createSelectorWeakMap = createSelectorCreator({
   memoize: weakMapMemoize,
-  argsMemoize: weakMapMemoize
+  argsMemoize: weakMapMemoize,
+  argsMemoizeOptions: {
+    resultEqualityCheck: shallowEqual
+  },
+  memoizeOptions: {
+    resultEqualityCheck: shallowEqual
+  }
 })
 
 const selectItemsByCategory = createSelectorWeakMap(