Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Exclude Folders from stats option is not working #102

Closed
kaffarell opened this issue Jun 3, 2020 · 2 comments · Fixed by #103
Closed

The Exclude Folders from stats option is not working #102

kaffarell opened this issue Jun 3, 2020 · 2 comments · Fixed by #103
Assignees
@tomice
Labels
bug 🐛

Comments

@kaffarell
Copy link

Describe the bug
I execute export _GIT_PATHSPEC=':!docs' in the terminal and there are no errors, however when I execute git-quick-stats and press for example 1 it shows:
fatal: unrecognized argument: -- :!docs total:

To Reproduce
Steps to reproduce the behavior:

  1. export _GIT_PATHSPEC=':!docs' in the terminal
  2. Open ./git-quick-stats and press 1

Expected behavior
It should show the stats without the specified folder

Desktop (please complete the following information):

  • OS: Ubuntu 20.04, Shell: zsh
@arzzen arzzen added the bug 🐛 label Jun 7, 2020
tomice added a commit to tomice/git-quick-stats that referenced this issue Jun 28, 2020
@tomice
Fix folder excluding pathspec bug arzzen#102
93aa829 
* There was an issue with quoting in the pathspec variable where
  the variable would get mangled when being passed to different
  parameters during git operations. This change fixes that.

Fixes arzzen#102
@tomice tomice mentioned this issue Jun 28, 2020
Merged
@tomice
Copy link
Collaborator

tomice commented Jun 28, 2020

Thanks for reporting the bug! Made a change that I believe fixes the issue. Let me know if this works out for you on your end and fixes the issue you are seeing.

arzzen added a commit that referenced this issue Jun 28, 2020
@arzzen
Merge pull request #103 from tomice/master
3b2f26e 
Fix folder excluding pathspec bug #102
@kaffarell
Copy link
Author

Works for me 🎉 , thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomice tomice

Labels
bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix folder excluding pathspec bug #102 tomice/git-quick-stats
3 participants
@arzzen @tomice @kaffarell