Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Build with LTS version of Node and AppVeyor #115

Closed
hypery2k opened this issue Jun 4, 2018 · 3 comments
Closed

Improvement: Build with LTS version of Node and AppVeyor #115

hypery2k opened this issue Jun 4, 2018 · 3 comments

Comments

@hypery2k
Copy link
Contributor

hypery2k commented Jun 4, 2018

The current travis configuration uses Node 7 to build. It would be better to stick to Node 8 or the upcoming NodeLTS version, see here for more.
Node 8 also improves overall install performance an dev machine. Maybe it would be also a good idea to test several NodeJS version, like here.
Besides that a ci build on AppVeyor would also ensure that the setup works on Windows machines.

I could sent a PR for these both issue.

@subsend
Copy link
Contributor

subsend commented Jun 4, 2018

Hey, thanks for Idea! 384575c

@Waschnick
Copy link
Contributor

@subsend upgraded to a newer node version with his commit (he forgot the PR and to mention the issue in the commit ;) )

AppVeyor may be a good idea, for testing windows, as I have a Windows machine at home ;) @hypery2k feel free to create a PR for the pull request

As for multiple node versions - what would be the benefit?

@hypery2k
Copy link
Contributor Author

hypery2k commented Dec 7, 2018

the multiple node version would just help in case for development. Sometimes dependencies and build stuff works differently in different version, so for a library on the use side no big issue

@rbuer rbuer closed this as completed Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants