-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the event 'oil_shown' is always sent in a certain configuration #191
Comments
subsend
pushed a commit
that referenced
this issue
Aug 16, 2018
subsend
pushed a commit
that referenced
this issue
Aug 16, 2018
# Conflicts: # test/specs/userview/userview_handle-optin.spec.js
subsend
pushed a commit
that referenced
this issue
Aug 16, 2018
ltparis2018
added a commit
that referenced
this issue
Aug 17, 2018
subsend
pushed a commit
that referenced
this issue
Aug 17, 2018
Hi jtamary, thx you for reporting this. we fixed this issue in a826033 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using the gdprApplies conditionally, the event 'oil_shown' is always sent even when the UI is not shown since it's not a GDPR country.
I think that the problem is because the user haven't opted in if he's not from a GDRP country:
oil/src/scripts/core/core_oil.js
Line 60 in d77b22e
and we check the gdprApplies only in:
https://github.com/as-ideas/oil/blob/master/src/scripts/userview/userview_modal.js#L126
but we send the event when optin is false:
oil/src/scripts/core/core_oil.js
Line 72 in d77b22e
Thanks,
Jonathan
The text was updated successfully, but these errors were encountered: