Unimplemented methods in master

[mimshwright]

It looks like there are several methods in validation that are not implemented. While it's good to do test driven development, there shouldn't be any works in progress checked into the library's master branch. Please make changes in a separate branch or fork and use a pull request to add them to the master branch when they're tested and ready.

Also, I'm not sure why but the tests in this package were causing errors for me in FlexUnit. And isUSAStateAbbreviationTest() has a compile error.

TypeError: Error #1034: Type Coercion failed: cannot convert []@1e0d6499 to Class.
at org.flexunit.runner::Description$/createSuiteDescription()[/Users/drew/Downloads/flexunit-flexunit-2746d3a/FlexUnit4/src/org/flexunit/runner/Description.as:220]
at org.flexunit.runner::FlexUnitCore/dealWithArgArray()[/Users/drew/Downloads/flexunit-flexunit-2746d3a/FlexUnit4/src/org/flexunit/runner/FlexUnitCore.as:147]
at org.flexunit.runner::FlexUnitCore/run()[/Users/drew/Downloads/flexunit-flexunit-2746d3a/FlexUnit4/src/org/flexunit/runner/FlexUnitCore.as:169]
at flexunit.flexui::FlexUnit4TestRunner/run()[C:\work\flex\ide_builder\com.adobe.flexbuilder.flexunit\flexunitframework\src\flexunit\flexui\FlexUnit4TestRunner.as:75]
at flexunit.flexui::FlexUnitTestRunnerUI/runWithFlexUnit4Runner()[C:\work\flex\ide_builder\com.adobe.flexbuilder.flexunit\flexunitframework\src\flexunit\flexui\FlexUnitTestRunnerUI.mxml:148]
at FlexUnitApplication/onCreationComplete()[/Users/mims/workspace/as3-utils/src/FlexUnitApplication.mxml:84]
at FlexUnitApplication/___FlexUnitApplication_Application1_creationComplete()[/Users/mims/workspace/as3-utils/src/FlexUnitApplication.mxml:9]
at flash.events::EventDispatcher/dispatchEventFunction()
at flash.events::EventDispatcher/dispatchEvent()
at mx.core::UIComponent/dispatchEvent()[E:\dev\4.x\frameworks\projects\framework\src\mx\core\UIComponent.as:12528]
at mx.core::UIComponent/set initialized()[E:\dev\4.x\frameworks\projects\framework\src\mx\core\UIComponent.as:1627]
at mx.managers::LayoutManager/doPhasedInstantiation()[E:\dev\4.x\frameworks\projects\framework\src\mx\managers\LayoutManager.as:759]
at mx.managers::LayoutManager/doPhasedInstantiationCallback()[E:\dev\4.x\frameworks\projects\framework\src\mx\managers\LayoutManager.as:1072]

[slackmage]

Mims, this isn't TDD - I'm just writing tests around what we already have. In any event there wasn't anything incomplete committed - all the tests pass. Did you pull down all the changes?

On May 25, 2011, at 11:04 AM, mimshwright wrote:

It looks like there are several methods in validation that are not implemented. While it's good to do test driven development, there shouldn't be any works in progress checked into the library's master branch. Please make changes in a separate branch or fork and use a pull request to add them to the master branch when they're tested and ready.

Also, I'm not sure why but the tests in this package were causing errors for me in FlexUnit. And isUSAStateAbbreviationTest() has a compile error.

TypeError: Error #1034: Type Coercion failed: cannot convert []@1e0d6499 to Class.
at org.flexunit.runner::Description$/createSuiteDescription()[/Users/drew/Downloads/flexunit-flexunit-2746d3a/FlexUnit4/src/org/flexunit/runner/Description.as:220]
at org.flexunit.runner::FlexUnitCore/dealWithArgArray()[/Users/drew/Downloads/flexunit-flexunit-2746d3a/FlexUnit4/src/org/flexunit/runner/FlexUnitCore.as:147]
at org.flexunit.runner::FlexUnitCore/run()[/Users/drew/Downloads/flexunit-flexunit-2746d3a/FlexUnit4/src/org/flexunit/runner/FlexUnitCore.as:169]
at flexunit.flexui::FlexUnit4TestRunner/run()[C:\work\flex\ide_builder\com.adobe.flexbuilder.flexunit\flexunitframework\src\flexunit\flexui\FlexUnit4TestRunner.as:75]
at flexunit.flexui::FlexUnitTestRunnerUI/runWithFlexUnit4Runner()[C:\work\flex\ide_builder\com.adobe.flexbuilder.flexunit\flexunitframework\src\flexunit\flexui\FlexUnitTestRunnerUI.mxml:148]
at FlexUnitApplication/onCreationComplete()[/Users/mims/workspace/as3-utils/src/FlexUnitApplication.mxml:84]
at FlexUnitApplication/___FlexUnitApplication_Application1_creationComplete()[/Users/mims/workspace/as3-utils/src/FlexUnitApplication.mxml:9]
at flash.events::EventDispatcher/dispatchEventFunction()
at flash.events::EventDispatcher/dispatchEvent()
at mx.core::UIComponent/dispatchEvent()[E:\dev\4.x\frameworks\projects\framework\src\mx\core\UIComponent.as:12528]
at mx.core::UIComponent/set initialized()[E:\dev\4.x\frameworks\projects\framework\src\mx\core\UIComponent.as:1627]
at mx.managers::LayoutManager/doPhasedInstantiation()[E:\dev\4.x\frameworks\projects\framework\src\mx\managers\LayoutManager.as:759]
at mx.managers::LayoutManager/doPhasedInstantiationCallback()[E:\dev\4.x\frameworks\projects\framework\src\mx\managers\LayoutManager.as:1072]

Reply to this email directly or view it on GitHub:
#13

[mimshwright]

Oh my gosh, i'm a jerk. I was looking at the tests instead of the source. Sorry!
Still, the tests are not implemented. Are you sure you checked them in or did you just not finish? If they're unfinished, maybe they shouldn't be checked in since that could be kinda confusing.

Anyway, I am still getting that error trace when i run the tests in that package using flash builder's Flex Unit functions. I did pull down all the changes.

I still think it would be good for us all to use pull requests so that at least 2 pairs of eyes sees each commit.

Thanks

[slackmage]

Mims, there is a Theory in the isUSAStateAbbreviationTest() - you aren't running a beta of flexunit 4 are you?

On May 25, 2011, at 11:04 AM, mimshwright wrote:

It looks like there are several methods in validation that are not implemented. While it's good to do test driven development, there shouldn't be any works in progress checked into the library's master branch. Please make changes in a separate branch or fork and use a pull request to add them to the master branch when they're tested and ready.

Also, I'm not sure why but the tests in this package were causing errors for me in FlexUnit. And isUSAStateAbbreviationTest() has a compile error.

TypeError: Error #1034: Type Coercion failed: cannot convert []@1e0d6499 to Class.
at org.flexunit.runner::Description$/createSuiteDescription()[/Users/drew/Downloads/flexunit-flexunit-2746d3a/FlexUnit4/src/org/flexunit/runner/Description.as:220]
at org.flexunit.runner::FlexUnitCore/dealWithArgArray()[/Users/drew/Downloads/flexunit-flexunit-2746d3a/FlexUnit4/src/org/flexunit/runner/FlexUnitCore.as:147]
at org.flexunit.runner::FlexUnitCore/run()[/Users/drew/Downloads/flexunit-flexunit-2746d3a/FlexUnit4/src/org/flexunit/runner/FlexUnitCore.as:169]
at flexunit.flexui::FlexUnit4TestRunner/run()[C:\work\flex\ide_builder\com.adobe.flexbuilder.flexunit\flexunitframework\src\flexunit\flexui\FlexUnit4TestRunner.as:75]
at flexunit.flexui::FlexUnitTestRunnerUI/runWithFlexUnit4Runner()[C:\work\flex\ide_builder\com.adobe.flexbuilder.flexunit\flexunitframework\src\flexunit\flexui\FlexUnitTestRunnerUI.mxml:148]
at FlexUnitApplication/onCreationComplete()[/Users/mims/workspace/as3-utils/src/FlexUnitApplication.mxml:84]
at FlexUnitApplication/___FlexUnitApplication_Application1_creationComplete()[/Users/mims/workspace/as3-utils/src/FlexUnitApplication.mxml:9]
at flash.events::EventDispatcher/dispatchEventFunction()
at flash.events::EventDispatcher/dispatchEvent()
at mx.core::UIComponent/dispatchEvent()[E:\dev\4.x\frameworks\projects\framework\src\mx\core\UIComponent.as:12528]
at mx.core::UIComponent/set initialized()[E:\dev\4.x\frameworks\projects\framework\src\mx\core\UIComponent.as:1627]
at mx.managers::LayoutManager/doPhasedInstantiation()[E:\dev\4.x\frameworks\projects\framework\src\mx\managers\LayoutManager.as:759]
at mx.managers::LayoutManager/doPhasedInstantiationCallback()[E:\dev\4.x\frameworks\projects\framework\src\mx\managers\LayoutManager.as:1072]

Reply to this email directly or view it on GitHub:
#13

[mimshwright]

I'm using Burrito (FB 4.5) so i guess maybe that's a beta version. The error I'm getting is equalTo() on line 21 should have 1 argument but it has 0.