Bug: don't invoke this.focusInput in mousetrap callback #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling this.focusInput() in the moustrap callback it is possible for this.commandPaletteInput.input to be null since this.commandPaletteInput is set during the render which is not guaranteed to happen first. This creates a race condition that can lead to an error being logged on the console in some cases. this.focusInput() is still called by afterOpenModal and thus the desired effect is acheived.
asabaylus
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1157 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 219 218 -1
Branches 35 35
=========================================
- Hits 219 218 -1
Continue to review full report at Codecov.
|
|
@DAlperin thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling this.focusInput() in the moustrap callback it is possible for this.commandPaletteInput.input (as used in this.focusInput()) to be null since this.commandPaletteInput is set during the render which is not guaranteed to happen first. This creates a race condition that can lead to an error being logged on the console in some cases.
this.focusInput() is still called by afterOpenModal and thus the desired effect is preserved.
I have published a package published that just bumps to react 18 and fixes this bug if you want to test out the changes really quickly. https://www.npmjs.com/package/react18-react-command-palette
Thank you for the awesome package. It saved me a ton of time and allowed me to put together a what would otherwise be complicated feature with extreme ease!