Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error typo version #1300

Merged
merged 1 commit into from
Aug 6, 2022
Merged

fix: Error typo version #1300

merged 1 commit into from
Aug 6, 2022

Conversation

olivermontes
Copy link
Contributor

Error from react and react-dom 17 compatibility

⚡: npm i --save react-command-palette
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: admin@undefined
npm ERR! Found: react-dom@17.0.2
npm ERR! node_modules/react-dom
npm ERR!   react-dom@"17.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react-dom@"16 -18" from react-command-palette@0.18.0
npm ERR! node_modules/react-command-palette
npm ERR!   react-command-palette@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 

@olivermontes
Copy link
Contributor Author

workaround: package.json


...
  "overrides": {
    "react-command-palette": {
      "react-dom": "$react-dom"
    }
  },
...

Copy link
Owner

@asabaylus asabaylus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@asabaylus asabaylus added bug patch Increment the patch version when merged labels Aug 6, 2022
@asabaylus asabaylus self-assigned this Aug 6, 2022
@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #1300 (9b53c42) into main (2035676) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1300   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          218       218           
  Branches        35        35           
=========================================
  Hits           218       218           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@asabaylus asabaylus changed the title Error typo version fix: Error typo version Aug 6, 2022
@asabaylus asabaylus merged commit a3e6430 into asabaylus:main Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants