Feat: Add displayTrigger boolean

[mcrowder65]

Add null option to props.trigger, so that the trigger won't render. ex:

<div id="main">
      <CommandPalette commands={commands} reactModalParentSelector="#main" trigger={null} open />
</div>   

[mcrowder65]

not sure why these are appearing. They're not in my commit locally.

[asabaylus]

@mcrowder65 the snapshot tests are failing and we need some docs in the readme after this can be merged. Out of curiosity why not use something like the following?

<ReactCommandPalette trigger={<div />} commands={commands} />

my suggestion for the README.md

displayTrigger a boolean that prevents the trigger from rendering. Useful when the command pallet will be opened externally.

[mcrowder65]

@asabaylus why not allow null for the trigger? I don't see why it needs to have a div at all?

[asabaylus]

@asabaylus why not allow null for the trigger? I don't see why it needs to have a div at all?

Good point, did you want to update the PR or shall I?

[mcrowder65]

@asabaylus addressed!

[asabaylus]

@mcrowder65, there are several failing tests. The pallet needs to render unless null is set, ex:

if(trigger !== null) {
     return (
       <div className="react-command-palette">
         <PaletteTrigger
           onClick={this.handleOpenModal}
           trigger={trigger}
           theme={theme.trigger}
         />
         {modal}
       </div>
     );
   }
   
   return modal;

We still need a unit test.

[codecov]

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (a4d3b9d) compared to base (85f1e14).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #1332   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          218       221    +3     
  Branches        35        36    +1     
=========================================
+ Hits           218       221    +3     

Impacted Files	Coverage Δ
src/command-palette.js	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.