Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Fix path to theme/css in example [skip-ci] #858

Merged
merged 2 commits into from
Sep 19, 2021
Merged

Documentation: Fix path to theme/css in example [skip-ci] #858

merged 2 commits into from
Sep 19, 2021

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Sep 11, 2021

Hey loving this project so far! Tried copying and pasting the paths in the sublime example. I think there's a missing /dist/.

Hey loving this project so far! Tried copying and pasting the paths in the sublime example. I think there's a missing `/dist/`.
@asabaylus
Copy link
Owner

@jtoar thanks for the PR, I’ll check it out shortly. Much appreciated

@asabaylus asabaylus added the documentation Changes only affect the documentation label Sep 19, 2021
@asabaylus asabaylus added this to In progress in Roadmap v1.0 via automation Sep 19, 2021
@asabaylus asabaylus self-assigned this Sep 19, 2021
@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #858 (0eff4fc) into main (8084645) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #858   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          213       213           
  Branches        30        30           
=========================================
  Hits           213       213           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8084645...0eff4fc. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Sep 19, 2021

Code Climate has analyzed commit 0eff4fc and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@asabaylus asabaylus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added the chrome and sublime theme. Much appreciated @jtoar

@asabaylus asabaylus changed the title Fix path to theme/css in example Fix path to theme/css in example [skip-ci] Sep 19, 2021
@asabaylus asabaylus changed the title Fix path to theme/css in example [skip-ci] Documentation: Fix path to theme/css in example [skip-ci] Sep 19, 2021
@asabaylus asabaylus merged commit 7c413ef into asabaylus:main Sep 19, 2021
Roadmap v1.0 automation moved this from In progress to Done Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation
Projects
Roadmap v1.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants