Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node to 14.x and fix-up tests for shouldFocusAfterRender #919

Merged
merged 14 commits into from
Jan 17, 2022

Conversation

asabaylus
Copy link
Owner

@asabaylus asabaylus commented Nov 21, 2021

Adds missing unit test coverage

@asabaylus asabaylus added the skip-release Preserve the current version when merged label Nov 21, 2021
@asabaylus asabaylus self-assigned this Nov 21, 2021
@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #919 (9bb0674) into main (bdd1446) will increase coverage by 1.82%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #919      +/-   ##
===========================================
+ Coverage   98.17%   100.00%   +1.82%     
===========================================
  Files           7         7              
  Lines         219       219              
  Branches       35        35              
===========================================
+ Hits          215       219       +4     
+ Misses          4         0       -4     
Impacted Files Coverage Δ
src/command-palette.js 100.00% <0.00%> (+2.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd1446...9bb0674. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Jan 17, 2022

Code Climate has analyzed commit 9bb0674 and detected 0 issues on this pull request.

View more on Code Climate.

@asabaylus asabaylus changed the title Fixup tests for shouldFocusAfterRender Bump node to 14.x and fix-up tests for shouldFocusAfterRender Jan 17, 2022
@asabaylus asabaylus merged commit d19b4bd into main Jan 17, 2022
@asabaylus asabaylus deleted the fixup-tests branch January 17, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant