Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples V1 #83

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Examples V1 #83

wants to merge 1 commit into from

Conversation

momintlh
Copy link
Collaborator

@momintlh momintlh commented Jun 20, 2024

Added examples into the package folder, currently the 2d platformer scene.

#65

Copy link
Collaborator

@SaadBazaz SaadBazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add a description in README to explain that there are some examples in the folder. You should probably add a link in the README to the folder as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always use kebab case for folder and file naming.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is just used in the game, keep it in the game's example folder.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep consistent naming. If it's 2d-hello-world, keep it that throughout. Else you can also rename the example to 2d-simple-platformer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants