Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes #59

Closed
wants to merge 2 commits into from
Closed

Themes #59

wants to merge 2 commits into from

Conversation

shikaan
Copy link

@shikaan shikaan commented Oct 18, 2016

I made the following changes:

  • *New feature: * You can choose between a couple of themes. Of course other themes can be added;
  • *New feature: * You can choose a path variable which is used to append the right style-sheet to the page, so you don't have to change your HTML if you want to change your theme;
  • I upgraded and updated the bower and the npm packages, since they were a bit outdated;
  • *Tests: * I have written some protractor test (a couple, since I am not able to simulate mouse wheel scrolling in selenium, any help is greatly appreciated) to test the link function
  • *Tests: * I added a controller, so I have written tests to... test it out.

I have also updated the README.md file and Gruntfile (I'm more a gulp guy, so probably this gruntfile isn't written at its best)

For any further information you can write me at:
spagnolo.manu@gmail.com

* Edited Gruntfile.js
* NEW FEATURE: path choosing (see the docs)
* TEST: Added some test cases for the controller (with Karma)
* TEST: Added some test cases for the link function (with Protractor)
@shikaan shikaan closed this Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant