Update specs to better GBM data fetching

spec/scoruby/models/gradient_boosted_model/data_spec.rb

@@ -9,28 +9,29 @@
   let(:categorical_features) { { Sex: %w[female male] } }
 
   it 'loads correct number of trees' do
-    expect(data.decision_trees.count).to eq 100
+    expect(data.decision_trees.count).to eq 15
   end
 
   it 'loads continuous features' do
-    expect(data.continuous_features).to be_empty
+    expect(data.continuous_features).to match_array %i[Survived Pclass Age Fare]
   end
 
   it 'loads categorical features' do
     expect(data.categorical_features).to match categorical_features
   end
 
   context 'const value' do
-    let(:const) { -0.4732877044469254 }
     context 'pmml 4.3' do
-      it 'loads correct number of trees' do
+      let(:const) { 1.3838383838383839 }
+      it 'loads const' do
         expect(data.const).to eq const
       end
     end
 
     context 'pmml 4.2' do
+      let(:const) { -0.4732877044469254 }
       let(:gbm_file) { 'spec/fixtures/titanic_gbm_4_2.pmml' }
-      it 'loads correct number of trees' do
+      it 'loads const' do
         expect(data.const).to eq const
       end
     end

spec/scoruby/models/gradient_boosted_model/model_spec.rb

@@ -5,36 +5,44 @@
 describe Scoruby::Models::GradientBoostedModel::Model do
   let(:xml) { Scoruby.xml_from_file_path(gbm_file) }
   let(:gbm) { described_class.new(xml) }
-  let(:approve_features) do
-    { Sex: 'male', Parch: 0, Age: 30, Fare: 9.6875,
-      Pclass: 2, SibSp: 0, Embarked: 'Q' }
-  end
-  let(:decline_features) do
-    { Sex: 'female', Parch: 0, Age: 38, Fare: 71.2833,
-      Pclass: 2, SibSp: 1, Embarked: 'C' }
-  end
 
   context 'pmml 4.3' do
     let(:gbm_file) { 'spec/fixtures/titanic_gbm.pmml' }
+    let(:features1) do
+      { Sex: 'male', Parch: 0, Age: 30, Fare: 9.6875,
+        Pclass: 2, SibSp: 0, Embarked: 'Q' }
+    end
+    let(:features2) do
+      { Sex: 'female', Parch: 0, Age: 38, Fare: 71.2833,
+        Pclass: 2, SibSp: 1, Embarked: 'C' }
+    end
 
     it 'predicts approve' do
-      expect(gbm.score(approve_features)).to eq 0.3652639329522468
+      expect(gbm.score(features1)).to eq 0.7990679530500985
     end
 
     it 'predicts decline' do
-      expect(gbm.score(decline_features)).to eq 0.4178155014037758
+      expect(gbm.score(features2)).to eq 0.8009413525080109
     end
   end
 
   context 'pmml 4.2' do
     let(:gbm_file) { 'spec/fixtures/titanic_gbm_4_2.pmml' }
+    let(:features1) do
+      { Sex: 'male', Parch: 0, Age: 30, Fare: 9.6875,
+        Pclass: 2, SibSp: 0, Embarked: 'Q' }
+    end
+    let(:features2) do
+      { Sex: 'female', Parch: 0, Age: 38, Fare: 71.2833,
+        Pclass: 2, SibSp: 1, Embarked: 'C' }
+    end
 
     it 'predicts approve' do
-      expect(gbm.score(approve_features)).to eq 0.3652639329522468
+      expect(gbm.score(features1)).to eq 0.3652639329522468
     end
 
     it 'predicts decline' do
-      expect(gbm.score(decline_features)).to eq 0.4178155014037758
+      expect(gbm.score(features2)).to eq 0.4178155014037758
     end
   end
 end