styling

lib/scoruby/models/gradient_boosted_model/model.rb

@@ -17,12 +17,16 @@ def initialize(xml)
 
         def score(features)
           formatted_features = Features.new(features).formatted
-          scores = decision_trees.map do |dt|
-            dt.decide(formatted_features).score.to_s.to_f
-          end
+          scores = traverse_trees(formatted_features)
           sum = scores.reduce(:+) + const
           Math.exp(sum) / (1 + Math.exp(sum))
         end
+
+        def traverse_trees(formatted_features)
+          decision_trees.map do |dt|
+            dt.decide(formatted_features).score.to_s.to_f
+          end
+        end
       end
     end
   end

spec/scoruby/models/gradient_boosted_model/model_spec.rb

@@ -5,12 +5,18 @@
 describe Scoruby::Models::GradientBoostedModel::Model do
   let(:xml) { Scoruby.xml_from_file_path(gbm_file) }
   let(:gbm) { described_class.new(xml) }
-  let(:approve_features) { { Sex: 'male', Parch: 0, Age: 30, Fare: 9.6875, Pclass: 2, SibSp: 0, Embarked: 'Q' } }
-  let(:decline_features) { { Sex: 'female', Parch: 0, Age: 38, Fare: 71.2833, Pclass: 2, SibSp: 1, Embarked: 'C' } }
+  let(:approve_features) do
+    { Sex: 'male', Parch: 0, Age: 30, Fare: 9.6875,
+      Pclass: 2, SibSp: 0, Embarked: 'Q' }
+  end
+  let(:decline_features) do
+    { Sex: 'female', Parch: 0, Age: 38, Fare: 71.2833,
+      Pclass: 2, SibSp: 1, Embarked: 'C' }
+  end
 
   context 'pmml 4.3' do
     let(:gbm_file) { 'spec/fixtures/titanic_gbm.pmml' }
-    
+
     it 'predicts approve' do
       expect(gbm.score(approve_features)).to eq 0.3652639329522468
     end