Fixing a big with set_entry response continue. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by an actual 200. That was causing the curl lib to incorrectly dump server headers into the json response and break the json_decode call. I've added a workaround to fix this.
asakusuma
added a commit
that referenced
this pull request
Apr 23, 2014
Fixing a big with set_entry response continue.
|
Thanks! |
|
No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SugarCRMs set_entry function returns a response like so:
HTTP/1.1 100 Continue
HTTP/1.1 200 OK
Date: Wed, 23 Apr 2014 15:02:32 GMT
That Continue response will break AlexSoft's curl function on this line:
list($responseParts['headersString'], $responseParts['body']) = explode("\r\n\r\n", $this->_response, 2);
This will dump everything, including the HTTP/1.1 200 OK and all other server headers into the output body(where only json should be), thereby breaking the json_decode function. I've added a workaround to fix this by sending an empty expect to circumvent the 100.