swift 3.0 #1
swift 3.0 #1
Conversation
| public func async (callback: Void -> Void) { | ||
| dispatch_async(dispatch_queue) { callback() } | ||
| open func async (_ callback: @escaping (Void) -> Void) { | ||
| dispatch_queue.async { callback() } |
There was a problem hiding this comment.
minor thing, but can we do dispatch_queue.async(callback)?
There was a problem hiding this comment.
we can do dispatch_queue.async(execute: callback)
| if isCurrent { callback(); return } // prevent deadlocks! | ||
| dispatch_sync(dispatch_queue) { callback() } | ||
| dispatch_queue.sync { callback() } |
| } | ||
|
|
||
| public func async <T> (callback: T -> Void) -> T -> Void { | ||
| open func async <T> (_ callback: @escaping (T) -> Void) -> (T) -> Void { | ||
| return { [weak self] value in | ||
| if self == nil { return } |
There was a problem hiding this comment.
can we convert this to guard let or is it too overkill? :D
There was a problem hiding this comment.
actually can we do self?.async { callback(value) }?
There was a problem hiding this comment.
done, actually i removed too the force unwrap from bellow
| return { [weak self] value in | ||
| if self == nil { return } | ||
| self!.async { callback(value) } | ||
| } | ||
| } | ||
|
|
||
| public func sync <T> (callback: T -> Void) -> T -> Void { | ||
| open func sync <T> (_ callback: @escaping (T) -> Void) -> (T) -> Void { | ||
| return { [weak self] value in | ||
| if self == nil { return } |
|
|
||
|
|
||
|
|
||
| // MARK: Internal | ||
|
|
||
| init (_ queue: dispatch_queue_t) { | ||
| init (_ queue: Dispatch.DispatchQueue) { |
There was a problem hiding this comment.
do we need the Dispatch. prefix here and in the other usages?
| remember() | ||
| } | ||
|
|
||
| func remember () { | ||
| dispatch_queue_set_specific(dispatch_queue, &kCurrentQueue, getMutablePointer(self), nil) | ||
| guard let mutablePoiner = getMutablePointer(self) else { |
| @@ -2,15 +2,15 @@ | |||
| import Foundation | |||
| import UIKit | |||
|
|
|||
| public typealias Timer = DispatchTimer | |||
There was a problem hiding this comment.
isn't this dangerous? Can it collide with NSTimer -> Timer?
There was a problem hiding this comment.
i can remove it all together but then we'll break the public API of the framework. i don't think it matters actually
There was a problem hiding this comment.
i removed this, Group and Dispatch typealiases
| dispatch_source_set_timer(timer, time, UInt64(delay_ns), UInt64(tolerance * CGFloat(NSEC_PER_SEC))) | ||
| dispatch_source_set_event_handler(timer) { [weak self] in let _ = self?.fire() } | ||
| dispatch_resume(timer) | ||
| let time = DispatchTime.now() + Double(Int64(delay_ns)) / Double(NSEC_PER_SEC) |
There was a problem hiding this comment.
maybe we don't need to divide by Double(NSEC_PER_SEC) if in the line before we don't multiply by CGFloat(NSEC_PER_SEC)
| let time = DispatchTime.now() + Double(Int64(delay_ns)) / Double(NSEC_PER_SEC) | ||
|
|
||
| let interval = DispatchTimeInterval.nanoseconds(Int(delay_ns)) | ||
| let leeway = DispatchTimeInterval.nanoseconds(Int(UInt64(tolerance * CGFloat(NSEC_PER_SEC)))) |
There was a problem hiding this comment.
maybe we can avoid double converting to UInt64 and Int
There was a problem hiding this comment.
are we sure that tolerance * CGFloat(NSEC_PER_SEC) will always be positive?
There was a problem hiding this comment.
you're converting to UInt64 anyway
| isConcurrent = true | ||
| dispatch_queue = dispatch_get_global_queue(priority, 0) | ||
| dispatch_queue = DispatchQueue.global(qos: qos) | ||
| remember() | ||
| } | ||
|
|
||
| init (_ concurrent: Bool) { |
There was a problem hiding this comment.
can we remove the _ so that the concurrent argument is explicit?
There was a problem hiding this comment.
i removed all of them on this class
No description provided.