Added Dialogue Datasets and RankingModel #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cle-ros
commented
Feb 21, 2020
cle-ros
commented
- added common model for downloading and extracting datsets
- added dialogue and ranking module
- added dstc7 dialogue dataset
- added ConvAI datasets
- added Ubuntu Dataset
- added RankingModel
- added dialogue and ranking module - added dstc7 dialogue dataset - added ConvAI datasets - added Ubuntu Dataset - added RankingModel
jeremyasapp
reviewed
Feb 22, 2020
| from flambe.field import Field | ||
|
|
||
|
|
||
| class CompressedDataTabularDataset(TabularDataset, metaclass=abc.ABCMeta): |
There was a problem hiding this comment.
I think it makes more sense to bake this functionality into the TabularDataset so everyone benefits from it
jeremyasapp
suggested changes
Feb 22, 2020
| super().__init__(train, val, test, cache, self.NAMED_COLS, transform) | ||
|
|
||
| @classmethod | ||
| def _download_and_extract_files(cls, **kwargs): |
There was a problem hiding this comment.
I would move this outside of the class as a utility and import it for usage in the TabularDataset
|
Put on ice until new data handling logic is implemented. See #273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.