chore: merge from next #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `super.{prop}`.
`update_year`'s old behavior was to simply overwrite the current year on file which is incorrect. This command now correctly updates the copyright so retaining first copyright year set and appending the succeeding years correctly. For example, if the year on the copyright file is `2020` and the current year is `2021`, then the correct modification should be `2020-2021`. Here are more conversions. For all examples, the current year is `2021`. `2020` -> `2020-2021` `2019` -> `2019, 2021` `2017, 2019` -> `2017, 2019, 2021` `2018, 2020` -> `2018, 2020-2021` Fixes #8.
This is related to #8. I've decided that the appropriate default behavior is to leave the LICENSE file alone and never update the copyright year. However, if you want the old behavior, append `-Y` to the command: ```sh release_tools prepare_release -wY ```
...for the breaking changes.
Pull Request Test Coverage Report for Build 8296034302Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.