Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to enable/disable ncsos globally #187

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Allow users to enable/disable ncsos globally #187

merged 1 commit into from
Apr 12, 2017

Conversation

lesserwhirls
Copy link
Contributor

Bring ncSOS into line with other TDS services by allowing users to enable/disable the service globally within threddsConfig.xml

Bring ncSOS into line with other TDS services by allowing users to enable/disable the service globally within threddsConfig.xml
@lesserwhirls
Copy link
Contributor Author

Fixes #186

The section of threddsConfig.xml looks like:

<NCSOS>
  <allow>false</allow>
</NCSOS>

The default is to disable the service, as this is a new service. However, in TDS v5.0, the default should be changed to true, as this will allow the use of ncSOS as a StandardService, which basically means it will be enabled and exposed by default on PointFeature Collections without the need for users to explicitly add the service in the configuration catalog.

@cheryldmorse cheryldmorse merged commit e1a95a1 into asascience-open:master Apr 12, 2017
@cheryldmorse
Copy link
Contributor

Nice. Thanks @lesserwhirls

@lesserwhirls
Copy link
Contributor Author

Great - thank you! Any idea when this will get into an artifact on your maven server? We are planning a release for next week, and it would be awesome to get this in for it (even if we reference a snapshot artifact). However, if that's too soon, I totally understand. We can pick it up on the next release. Thank you @cheryldmorse!

@cheryldmorse
Copy link
Contributor

Hi @lesserwhirls, Version 1.4.3 is now on the maven server.

@lesserwhirls
Copy link
Contributor Author

Awesome, thank you @cheryldmorse!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants