Merge pull request #134 from asdine/fix/errorsByField

Fix ErrorsByField when using custom validators

validator.go

@@ -903,7 +903,10 @@ func ErrorsByField(e error) map[string]string {
 		m[e.(Error).Name] = e.(Error).Err.Error()
 	case Errors:
 		for _, item := range e.(Errors).Errors() {
-			m[item.(Error).Name] = item.(Error).Err.Error()
+			n := ErrorsByField(item)
+			for k, v := range n {
+				m[k] = v
+			}
 		}
 	}
 

validator_test.go

@@ -2303,6 +2303,35 @@ func TestErrorsByField(t *testing.T) {
 			t.Errorf("Expected ErrorsByField(%q) to be %v, got %v", test.param, test.expected, actual)
 		}
 	}
+
+	type StructWithCustomValidation struct {
+		Email string `valid:"email"`
+		ID    string `valid:"falseValidation"`
+	}
+
+	CustomTypeTagMap.Set("falseValidation", CustomTypeValidator(func(i interface{}, o interface{}) bool {
+		return false
+	}))
+
+	tests = []struct {
+		param    string
+		expected string
+	}{
+		{"Email", "My123 does not validate as email"},
+		{"ID", "duck13126 does not validate as falseValidation"},
+	}
+	s := &StructWithCustomValidation{Email: "My123", ID: "duck13126"}
+	_, err = ValidateStruct(s)
+	errs = ErrorsByField(err)
+	if len(errs) != 2 {
+		t.Errorf("There should only be 2 errors but got %v", len(errs))
+	}
+
+	for _, test := range tests {
+		if actual, ok := errs[test.param]; !ok || actual != test.expected {
+			t.Errorf("Expected ErrorsByField(%q) to be %v, got %v", test.param, test.expected, actual)
+		}
+	}
 }
 
 func TestValidateStructPointers(t *testing.T) {