Fix validation of IPv4-mapped IPv6 addresses #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, 😄 |
asaskevich
added a commit
that referenced
this pull request
Nov 28, 2015
Fix validation of IPv4-mapped IPv6 addresses
Adirio
reviewed
Jan 30, 2018
| @@ -458,13 +458,13 @@ func IsIP(str string) bool { | |||
| // IsIPv4 check if the string is an IP version 4. | |||
| func IsIPv4(str string) bool { | |||
| ip := net.ParseIP(str) | |||
| return ip != nil && ip.To4() != nil | |||
| return ip != nil && strings.Contains(str, ".") | |||
There was a problem hiding this comment.
::FFFF:127.0.0.1 is a valid IPv6 address that contains .
You could swap it for return ip != nil && !strings.Contains(str, ":").
There was a problem hiding this comment.
If ports could be appended at the end, both method would need to be changed to strings.Count(str, ":") < 2 and strings.Count(str, ":") >= 2 respectively.
brb
added a commit
to cilium/cilium
that referenced
this pull request
Jul 23, 2019
Previously, we tried to provision a NodePort service for IPv6 depending
on whether `--enable-ipv6` was set to true which was wrong, as enabling
IPv6 does not mean that each Service definition will be in IPv6.
Unfortunately, "net.ParseIP([...]).To{4,16}()" is not reliable enough
to determine whether a clusterIP is in IPv6 or IPv4, thus the hack:
asaskevich/govalidator#100.
Fixes: 64568ff ("k8s: Add NodePorts field to Service struct")
Signed-off-by: Martynas Pumputis <m@lambda.lt>
borkmann
pushed a commit
to cilium/cilium
that referenced
this pull request
Jul 23, 2019
Previously, we tried to provision a NodePort service for IPv6 depending
on whether `--enable-ipv6` was set to true which was wrong, as enabling
IPv6 does not mean that each Service definition will be in IPv6.
Unfortunately, "net.ParseIP([...]).To{4,16}()" is not reliable enough
to determine whether a clusterIP is in IPv6 or IPv4, thus the hack:
asaskevich/govalidator#100.
Fixes: 64568ff ("k8s: Add NodePorts field to Service struct")
Signed-off-by: Martynas Pumputis <m@lambda.lt>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Addresses like ::ffff:c0a8:101 are marked as invalid IPv6 addresses and valid IPv4 addresses :
http://play.golang.org/p/4tNuUR7_yq
This is related to the way addresses are handled in the net/ip package ([16]byte array for both types).
Seems the easiest way to deal with this, is to check if the string is an IP address and, depending on the type, if it contains a dot or a column.
Ref: This discussion on stackoverflow, this issue and the code of ParseIP