Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give me #22

Open
wants to merge 79 commits into
base: google-music
Choose a base branch
from
Open

Give me #22

wants to merge 79 commits into from

Conversation

gzhang1337
Copy link

Let me contribute

newgiin added 30 commits May 2, 2013 23:22
@newgiin
Made the display pretty with room for controls. Organized code in fol…
1258d9b 
…ders.
@newgiin
Supports songs over an hour long
4e6a054
@newgiin
Support new Google Play interface.
a6e12e7
@newgiin
Scrobbles album. Continues to submit now playing after scrobble.
2cfa0fe
@newgiin
Play link switches to an existing Google Play tab if one is already o…
076176b 
…pen.
@newgiin
Display album name
aa0ba8c
@newgiin
Stop caching GET requests. Love button works now.
28f34a0
@newgiin
Updated README
9e30a67
@newgiin
Added last.fm to project name.
bc055b8
@newgiin
Higher marquee threshold to prevent jittering.
c9feaa0
@newgiin
Works with Play Music update
01f3760
@newgiin
gets time correctly
1b4532c
@newgiin
Mostly finished button implementation. Some minor bugs left.
f87d280
@newgiin
Finished player control buttons
bc12f40
@newgiin
woops, play/pause toggles icon now when scrobbling.
6696228
@newgiin
Removed redundant line
4034826
@newgiin
Restarts playlists correctly when scrobbling and using 'next' button
f8a8f1e
@newgiin
Working on scrobbling long mixes multiple times.
6ef1c85
@newgiin
Display player controls when not logged in. Only display scrobble lin…
c6003a5 
…k when logged in.
@newgiin
Scrobble every 4 minutes.
b72bb36
@newgiin
Some work on new scrobbling method.
48162a7
@newgiin
Scrobbles based solely on time played rather than song position.
b368c5a
@newgiin
Fixed image sprite. Images weren't isolated on Linux client.
aa93922
@newgiin
Scrobble interval increased to 8 minutes.
211db53
@newgiin
Moved the player controls down a bit.
1528b64
@newgiin
Reset time_played when at beginning of song to prevent over-scrobblin…
a64a273 
…g when playing a song on repeat.
@newgiin
Background page to event page. Use chrome.runtime.
b479b19 
Converted the background page to an event page,
saving memory when not listening to music.
See: http://developer.chrome.com/extensions/event_pages.html

Use newer chrome.runtime API instead of chrome.extension.
@newgiin
Reduced scrobble interval to 7 minutes.
8af2ce9
@newgiin
Error logging for last.fm calls
891e008
@newgiin
Added web_accessible_resources to manifest
9d48027
gzhang1337 and others added 30 commits February 8, 2015 01:49
@gzhang1337
marquee changed to span
f34705c
@newgiin
Merge pull request #21 from gzhang1337/google-music
355855c 
marquee changed to span
@newgiin
Update version number
efcfcd3
Upd: Moves to or opens Google Play on Last.fm authentication.
b59beab
Oops: Tidy up indentation.
668470b
@newgiin
Merge pull request #26 from nathanbrock/open-gplay-on-auth
fe7e3fa 
Moves to or opens Google Play on Last.fm authentication.
@newgiin
Update version to 1.6.3
b25d948
@newgiin
Fix scrobbling with material UI.
c95bbcc
@newgiin
Song info updates properly when you press player controls.
294add7
@DHNishi
Instead of assuming that the refresh is every 2 seconds, calculate th…
ae767ee 
…e time since the last refresh.
@newgiin
Merge pull request #29 from DHNishi/google-music
4ef685a 
Instead of assuming that the refresh is every 2 seconds, calculate th…
@newgiin
Move some stuff around.
01d35fd
@newgiin
Handle if HTML has paper-icon elements instead of sj-icon elements.
1cb4384
@newgiin
update contentscript
0e00030
@byted
do not scrobble google music advertisments
b35716b
@newgiin
Merge pull request #33 from byted/google-music
a35275e 
do not scrobble google music advertisments
@newgiin
Bump manifest to 1.6.9
2f17fd0
@tims
closes #38, send now playing request only once with the correct duration
2da06b5
@newgiin
Merge pull request #39 from tims/google-music
9ee4f28 
closes #38, send now playing request only once with the correct duration

Suppose the user could pause the song, and it'd be arguable
@newgiin
bump version to 1.7.0
e07033c
@newgiin
Set indent to two spaces. Cleanup style in background.js
8d99df2
@newgiin
- Add logging option.
c0ebfe0 
- Change some localstorage calls to use getItem().
- various linting.
@newgiin
Log vars that trigger scrobble. Fix options page checkbox. Bump versi…
b5103bf 
…on number.
@newgiin
Check if song length is non-null/zero before scrobbling. Not sure how…
f7b9f19 
… this happens, but it does.
@newgiin
YouTube Music integration.
51bf71c
@newgiin
Reverting some unintended changes.
6d5b9f1
@bulhi
Fix YtMusic is_playing detection - check browser tab title instead of…
5187e5f 
… button title, which is translated into user's locale, so it's not always "Pause".
@newgiin
Merge pull request #46 from bulhi/yt-music-fix
d337834 
Fix YtMusic is_playing detection - check browser tab title instead of…
@newgiin
Remove 'tabs' permission
35f1571 
Remove 'tabs' permission to pass Play store privacy restrictions.
@newgiin
Update album art selector.
2629b72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gzhang1337 @newgiin @fevrin @DHNishi @byted @tims @bulhi