vteFeedChild

[hanspr]

@egmontkob

I do not know how to reach you, but after a lot of testing I came to the conclusion that this sub should be rewritten like this, otherwise you get the array reference on the terminal instead of the text. I think that the perl library handles the passing of arguments inside.

I have tested and it works fine like this, the other way around does not work.

But I would like to check with you.

[hanspr]

Will close, already got my self the answer, and created the PR to fix.

[egmontkob]

This is Perl magic, and I'm not that familiar with Perl to comment on this. However, I'm curious:

• What's the bug that it fixes?
• Have you tested with accented letters?
• Shouldn't _vteFeed() and _vteFeedChildBinary also receive this change?

[hanspr]

You can read the original bug report on #205

The bug is this one

You type an "a" on one terminal, and using vteFeedChild should be passed to the second terminal as an "a", but as you see in the image, it arrives as ARRAY(0x......), which is the reference and not the letter.

After changing it like that, you get this : type "ll" and is copyed correctly to the second terminal.

With respect to accented letters, huuh, it has issues in did.

This complicates things a little bit more, then, maybe using vteFeedChildBinary?

Now, I'll have to do more testing.

[hanspr]

fiiiixed !

I will have to send another PR, this guys are going to hallucinate me.

[KlaasT]

I was a bit shocked by the number of PRs when I came online today. Really great job. Very much appreciated :-)

[egmontkob]

Cool, thanks!