Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof of concept #94

Merged
merged 3 commits into from
Mar 31, 2021
Merged

Proof of concept #94

merged 3 commits into from
Mar 31, 2021

Conversation

coleweusthem
Copy link
Contributor

This should allow us to run multiple instances.

@coleweusthem
Copy link
Contributor Author

This also addresses #35, I used that issue to test it worked

@coleweusthem
Copy link
Contributor Author

also #37

@nfee006 nfee006 self-requested a review March 31, 2021 18:44
nfee006
nfee006 approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@nfee006 nfee006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for #35 and #37. I'm assuming more work will be need to be done on my side to get the translation to work, right?

@coleweusthem
Copy link
Contributor Author

@nfee006, I used the text you provided, so just changing the language in the config should do it.

@nfee006
Copy link
Member

nfee006 commented Mar 31, 2021

@coleweusthem yep looks good - I just need to set it up on my side with 2 instances of the app.

@coleweusthem coleweusthem merged commit ea1555c into Development Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfee006 nfee006 nfee006 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coleweusthem @nfee006