Fixed setPath and updatePath not returning unary functions

ascartabelli · Mar 9, 2018 · a547846 · a547846
1 parent 31319be
commit a547846
Show file tree

Hide file tree

Showing 7 changed files with 49 additions and 11 deletions.
diff --git a/dist/lamb.js b/dist/lamb.js
@@ -1,7 +1,7 @@
 /**
  * @overview lamb - A lightweight, and docile, JavaScript library to help embracing functional programming.
  * @author Andrea Scartabelli <andrea.scartabelli@gmail.com>
- * @version 0.55.0-alpha.1
+ * @version 0.55.0-alpha.3
  * @module lamb
  * @license MIT
  * @preserve
@@ -46,7 +46,7 @@
          * @since 0.53.0
          * @type String
          */
-        "@@lamb/version": {value: "0.55.0-alpha.1"}
+        "@@lamb/version": {value: "0.55.0-alpha.3"}
     });
 
     // prototype shortcuts
@@ -3436,7 +3436,9 @@
      * @returns {Function}
      */
     function setPath (path, value, separator) {
-        return partialRight(setPathIn, [path, value, separator]);
+        return function (source) {
+            return setPathIn(source, path, value, separator);
+        };
     }
 
     /**
@@ -3637,7 +3639,9 @@
      * @returns {Function}
      */
     function updatePath (path, updater, separator) {
-        return partialRight(updatePathIn, [path, updater, separator]);
+        return function (source) {
+            return updatePathIn(source, path, updater, separator);
+        };
     }
 
     /**

diff --git a/dist/lamb.min.js b/dist/lamb.min.js
diff --git a/dist/lamb.min.js.map b/dist/lamb.min.js.map
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -34,7 +34,7 @@
     "coveralls": "gulp coverage && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage"
   },
   "tonicExample": "var _ = require('lamb');",
-  "version": "0.55.0-alpha.2",
+  "version": "0.55.0-alpha.3",
   "devDependencies": {
     "coveralls": "^3.0.0",
     "gulp": "^3.9.1",

diff --git a/src/accessors.js b/src/accessors.js
@@ -358,7 +358,9 @@ var setKey = _makePartial3(setIn);
  * @returns {Function}
  */
 function setPath (path, value, separator) {
-    return partialRight(setPathIn, [path, value, separator]);
+    return function (source) {
+        return setPathIn(source, path, value, separator);
+    };
 }
 
 /**
@@ -559,7 +561,9 @@ var updateKey = _makePartial3(updateIn);
  * @returns {Function}
  */
 function updatePath (path, updater, separator) {
-    return partialRight(updatePathIn, [path, updater, separator]);
+    return function (source) {
+        return updatePathIn(source, path, updater, separator);
+    };
 }
 
 /**

diff --git a/test/spec/accessorsSpec.js b/test/spec/accessorsSpec.js
@@ -859,6 +859,21 @@ describe("lamb.accessors", function () {
                     expect(lamb.setPathIn(obj, "b.a.g", 99)).toEqual(r);
                 });
 
+                it("should ignore extra arguments passed to the built function in its partially applied form", function () {
+                    var r = lamb.setPath("b.c", "bar")(obj, {});
+
+                    expect(r).toEqual({
+                        a: 2,
+                        b: {
+                            a: {g: 10, h: 11},
+                            b: [4, 5],
+                            c: "bar",
+                            d: [, 55, ,] // eslint-disable-line comma-spacing, no-sparse-arrays
+                        },
+                        "c.d": {"e.f": 6}
+                    });
+                });
+
                 it("should allow custom separators", function () {
                     var r = lamb.setPath("c.d->e.f", 99, "->")(obj);
 
@@ -1233,6 +1248,21 @@ describe("lamb.accessors", function () {
                     expect(lamb.updatePathIn(obj, "b.a.g", double)).toEqual(r);
                 });
 
+                it("should ignore extra arguments passed to the built function in its partially applied form", function () {
+                    var r = lamb.updatePath("b.a.h", double)(obj, {});
+
+                    expect(r).toEqual({
+                        a: 2,
+                        b: {
+                            a: {g: 10, h: 22},
+                            b: [4, 5],
+                            c: "foo",
+                            d: [, 55, ,] // eslint-disable-line comma-spacing, no-sparse-arrays
+                        },
+                        "c.d": {"e.f": 6}
+                    });
+                });
+
                 it("should allow custom separators", function () {
                     var r = lamb.updatePath("c.d->e.f", double, "->")(obj);