Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that the total count of records to return does not exceed 2,000 #7

Closed
aschleg opened this issue Jun 26, 2018 · 1 comment
Closed

Check that the total count of records to return does not exceed 2,000 #7

aschleg opened this issue Jun 26, 2018 · 1 comment
Assignees
@aschleg
Labels
enhancement

Comments

@aschleg
Copy link
Owner

aschleg commented Jun 26, 2018

The Petfinder API limits a single call to a maximum of 2,000 records. The only way to return a max 2,000 records is to use the pages parameter in combination with the count parameter. If the multiple of pages and count exceeds 2000, raise ValueError.
@aschleg aschleg self-assigned this Jun 26, 2018
aschleg pushed a commit that referenced this issue Jun 27, 2018
commit to fix issues #6 and #7, added more test coverage
9741f69
@aschleg
Copy link
Owner Author

aschleg commented Jun 27, 2018

Issue fixed with commit 9741f69. Test added to ensure behavior is consistent with desired functionality.

@aschleg aschleg closed this as completed Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aschleg aschleg

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aschleg