Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle and SDK version. Also fixes a segfault. #26

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

kyleatmakrs
Copy link
Contributor

With these changes, Vinyl Cast now builds under the current Android Studio (hedgehog).

  • Gradle 8.5
  • targetSdkVersion 34

@aschober aschober self-requested a review December 23, 2023 19:03
@Hedda
Copy link

Hedda commented Jan 9, 2024

@aschober Any chance you can merge this + release a new version here and an updated Android build on the Google Play Store?

https://play.google.com/store/apps/details?id=tech.schober.vinylcast.playstore

@kyleatmakrs If not and this project is abandoned then any chance you could release an updated fork under a different name?

https://github.com/aschober/vinyl-cast/forks

Myself and others would love an updated version released on the Google Play Store, and preferably as an improved variant! 😉

  • 24-bit output option would be very nice as there are 24-bit USB sound cards, like example Behringer UMC202HD, Behringer UMC204HD, Lexicon Alpha, (and note that 24-bit output can still sound better than 16-bit output even if the source is 16-bit).

@kyleatmakrs
Copy link
Contributor Author

Just trying to upstream some fixes I made for myself. I don't have time to maintain a fork.

I emailed @aschober before sending the PR, and he suggested that he'd be interested in reviewing it.

@aschober
Copy link
Owner

@kyleatmakrs @Hedda appreciate the interest and contributions! I'm looking at the PRs now and my goal is to get an update published. May take me longer than usual to re-pick this up but my aim is to get an update published.

- Bump AGP to 8.2.1
- Update flavorDimensions syntax
- Bump Crashlytics NDK
@aschober aschober merged commit 67c8b8a into aschober:master Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants