Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clearSubject before setSubject #57

Closed
wants to merge 2 commits into from
Closed

Add clearSubject before setSubject #57

wants to merge 2 commits into from

Conversation

kassner
Copy link

@kassner kassner commented Sep 4, 2014

In a very few cases, I'd experienced some Subject set twice exceptions. We can clear the subject before to avoid any exception.

@aschroder
Copy link
Owner

Thanks for the pull request. I too have seen this error, and I agree that the extension could prevent it by clearing the subject right before setting it just as you have suggested.

However, I do not think this change should be made in SMTP Pro. The parts of the extension where you suggest modification mirror the core Magento functionality intentionally. This is important so that any email that did or did not send in core Magento, will have the same behavior in SMTP Pro.

I'll close this PR but suggest any one facing the subject set twice error coms here for a patch.

@aschroder aschroder closed this Oct 13, 2014
@vishalpatel14
Copy link

Does it support Multi-Website Magento Email configurations for different servers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants