-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TextFields, added support for delegate, make Demo.app an Agent, general cleanup, update README #7
Conversation
- Demo app is now agent-application - added methods to toggle Popover, updated Demo - added AXStatusItemPopupDelegate - updated Project preferences (suggested by Xcode) - Popup is now FirstResponder when open, updated Demo
{ | ||
[self hidePopover]; | ||
} else { | ||
[self showPopoverAnimated:self.isAnimated]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it should be [self showPopoverAnimated:animated]; here, instead of self.isAnimated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course your right. I'll change it and update the pull request.
I can confirm this commit is great. Would be good to get it rolled in. |
Thanks :) |
thanks for your effort, the changes look great. However, I noticed that some parts of the pull request have a different coding style compared to the original project. Here are some examples:
Could you make these changes to match the style of the rest of the project? |
As stated, I'm busy in the moment. You're right, it would have been better to keep the coding style in mind, I just added the changes as part of my project, later I thought about submitting a pull request. |
That would be great! |
With this implementation the
doesn't seem to fire on osx 10.7 and 10.8 any ideas? The problem seems to be the imageview added programatically to the statusitem. It seems that you have to subclass the imageview and override hitTest method |
Are you still interested in this? I saw that @joeljfischer made some changes, but you didn't merged it yet. I now would have time for it, but as this work is so stupid I want to be sure it's worth it. |
@ShadowLightz still interested in it. Have been away for a while, but might have some time on the weekend to look into all open issues. |
I close this now, I made a new one with the style changes. Look at PR #21. |
Thanks @ShadowLightz ! |
You're welcome! |
I think you know the issue with NSPopover in the Status Bar, I researched in the web about it and finally solved this problem. I also define a protocol for delegating, I think this can be useful. To simplify some tasks I also add
togglePopover
andtogglePopoverAnimated:
.Demo.app is now an agent. When I make the Popover FirstResponder, the MainMenu appeared and in addition there were some troubles with fullscreen apps. This change fixes this.
In the moment there is a problem when you open an additional Popover in the Status-Popover. To resolve this, you need to close this before you close the Status-Popover. To do this, the delegate method
popupWillClose
can be used. I added a note in the README.For better overview I added the necessary NSWindow-category to AXStatusItemPop.h und .m, so these two files are the only needed in future, too.
The other pull request isn't needed anymore. This also fixes the trouble with the Popup-Project.
I updated the Demo-Project (there are two new buttons to toggle the popover and the popover now contains a NSTextField).