-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building with asciidoctorj 1.5.3 results in "Ignoring..." messages #52
Comments
Which version of AsciidoctorJ and JRuby? Very likely this is a change in JRuby and the warning is harmless (though annoying). JRuby doesn't build extensions, hence why it claims they aren't built. The other possibility is that the extensions are marked as built (in some way) with one version of JRuby and running under a different version. @pepijnve may have some ideas as well. |
asciidoctorj: 1.5.3.2 |
Wait, I remember what this is. When you get that message, it means that there are locally installed gems visible to the JRuby runtime, likely installed using MRI (CRuby). Whenever you use AsciidoctorJ, it's a good idea to make sure you don't have RVM active, or other gems installed.
While we do isolate from loading these gems, it appears that JRuby is still analyzing them (at least, I hope it's not trying to load them too). |
Ah, that did the trick. Thanks Dan! |
What this tells me is that when you invoke AsciidoctorJ, you aren't isolating from the system gems. I don't get this warning when using the main Gradle plugin. Stay tuned for details. |
Ah, I'll reopen then. |
FYI, I do have the gem-path set. I also spoke too soon, it seems the build now fails on asciidoctor-diagram not being available:
|
Where is this sample project? |
Here: https://github.com/johncarl81/asciidoclet-sample build with |
So here's your problem regarding the warnings:
You should never be setting the gem path to the system (unless you really intend to do that, so we leave it as an option). It makes the build system dependent. To use the gem that jrubyPrepareGems installs, you should use a build-local path:
So, in total, those two options are:
Btw, you don't have to install the asciidoctor-diagram gem manually anymore since you can now use asciidoctorj-diagram (see https://bintray.com/asciidoctor/maven/asciidoctorj-diagram/1.3.1/view). Then, you can get rid of both options and the jrubyPrepareGems business. |
Btw, it might be good to add this sample project to the https://github.com/asciidoctor/asciidoctor-gradle-examples for exposure (even though technically it is not the Asciidoctor Gradle plugin, it still fits in the ecosystem there). |
Ah, good idea, I'll make a PR with the updated project soon.
|
👍 |
What do you think about the gradle file now, did I capture everything you mentioned: https://github.com/johncarl81/asciidoclet-sample/blob/master/build.gradle It's a little strange to register the asciidoctor-diagram plugin twice... is there any way to automatically register it with Asciidoctorj so to avoid the |
WDYT @mojavelinux: #53 |
The |
Hmm, removing the ptions.addStringOption "r", "asciidoctor-diagram" gives the following warnings then (and doesn't render the diagrams):
|
Hi, -r asciidoctor-diagram is still required. Cheers
|
Ah, my mistake. |
When building with an upgraded version of asciidoctorj, log messages are issued noting that it is ignoring a given library and to try to run a gem command:
@mojavelinux or @robertpanzer any thoughts on this one?
The text was updated successfully, but these errors were encountered: