-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for graphviz-py #379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the contribution!
@pepijnve You are welcome! Thanks for approving my code! |
I had a look at your graphviz-py project in detail this morning. I'm wondering if an extra integration is actually necessary here. Since you support the same CLI interface as |
@pepijnve Thank you so much for the reminder! I forgot to add an argument for variables. This makes it possible to calculate the same diagram with different values. I think that is very convenient. [graphviz_py, "graphviz_py_example", "SVG", argument="foo=5;bar=7"]
----
include::my_diagram.py.dot[]
----
[graphviz_py, "graphviz_py_example", "SVG", argument="foo=24;bar=32"]
----
include::my_diagram.py.dot[]
---- |
From my side, it is ready for merging now! |
@pepijnve Thank you for merging! I am looking forward to the new version :) |
I'm picking up maintenance work again after a bit of a hiatus. A new release should be ready later today. |
@pepijnve Thank you! That is great! |
graphviz-py makes it possible to run Python code inside of Graphviz diagrams, as well as using variables. I extended asciidoctor-diagram to support it.