Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sony readers crash #152

Closed
roskenet opened this issue Dec 30, 2017 · 12 comments
Closed

Sony readers crash #152

roskenet opened this issue Dec 30, 2017 · 12 comments
Labels

Comments

@roskenet
Copy link

Output ePub make Sony readers (at least PRS-505 and PRS-T1) crash when opening the text after the cover image.
The reason is the padding in pre at line 923 in epub3.css.
Commented out, it shows up correctly. I don't have any idea why this simple style causes trouble for the reader and it seems to be more a bug in the reader itself than in the stylesheet.
Maybe this report is helpful for Sony PRS owners.

@mojavelinux
Copy link
Member

This sounds to me like a bug that needs to reported with Sony. No style should be causing a reader to crash. I'm not prepared to change CSS to fix buggy software.

@crees
Copy link

crees commented Mar 2, 2020

Sony won't ever fix this as the reader is discontinued. Does it make a huge difference, modifying the CSS? It would make a huge difference to your users with Sony readers!

@mojavelinux
Copy link
Member

I have since changed my position on this. The CSS should be as simple as possible so as to support the most readers, because trying to the readers to change is futile. If you open a new issue with information that reflects the current stylesheet, I'm sure @slonopotamus will consider it.

@slonopotamus
Copy link
Contributor

slonopotamus commented Mar 2, 2020

I think I can get access to PRS-600.

@crees can you provide an example document that causes the crash?

@slonopotamus
Copy link
Contributor

slonopotamus commented Mar 3, 2020

Okay, I got PRS-350 and it does crash when trying to open the first page of our data/samples/sample-book.adoc.

@slonopotamus slonopotamus reopened this Mar 3, 2020
@slonopotamus
Copy link
Contributor

For the reference, here's problematic CSS rule. I suspect that @roskenet put nontrivial amounts of time into diagnosing crash down to this single CSS line.

WRT fixing it - I don't want to just remove the padding, code blocks look awful without it. Need to do some experiments, possibly will be able to find a workaround.

@slonopotamus slonopotamus added this to the v1.5.0.alpha.15 milestone Mar 3, 2020
@mojavelinux
Copy link
Member

mojavelinux commented Mar 3, 2020

It could be the units. That's just a shot in the dark, but worth checking.

@slonopotamus
Copy link
Contributor

slonopotamus commented Mar 4, 2020

It could be the units.

Exactly. Replaced rem with approximated em value.

rem-em

@crees
Copy link

crees commented Mar 4, 2020

Oh awesome, thanks both! I'm sorry, didn't see the alert emails for replies.

@mojavelinux
Copy link
Member

em unit could compound. It might be safer to use the equivalent pixel value (which is really all rem is, just simpler to reason about).

@slonopotamus
Copy link
Contributor

Agreed, will change.

@slonopotamus
Copy link
Contributor

Agreed, will change.

This got a bit delayed, but now fixed in 0d33f21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants