Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #268 provide a human-readable error message when we fail to find Kindlegen #271

Merged
merged 1 commit into from
Jan 27, 2020
Merged

resolves #268 provide a human-readable error message when we fail to find Kindlegen #271

merged 1 commit into from
Jan 27, 2020

Conversation

slonopotamus
Copy link
Contributor

No description provided.

@slonopotamus slonopotamus added this to the v1.5.0.alpha.12 milestone Jan 26, 2020
@slonopotamus slonopotamus mentioned this pull request Jan 26, 2020
Closed
mojavelinux
mojavelinux requested changes Jan 27, 2020
View reviewed changes
Copy link
Member

@mojavelinux mojavelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "G" in KindleGen should be capitalized.

Instead of saying how to install the gem, I recommend a simpler phrase:

install the kindlegem gem to add support

@slonopotamus
Copy link
Contributor Author

@mojavelinux Is it better now?

@mojavelinux mojavelinux self-requested a review January 27, 2020 07:25
mojavelinux
mojavelinux approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@mojavelinux mojavelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

@slonopotamus slonopotamus merged commit 39f3bbd into asciidoctor:master Jan 27, 2020
@slonopotamus slonopotamus deleted the kindlegen-load-error branch January 27, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mojavelinux mojavelinux mojavelinux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0.alpha.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slonopotamus @mojavelinux