resolves #282 use imagedir from an image's context during packaging #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slonopotamus
force-pushed
the
imagesdir
branch
7 times, most recently
from
a7f898a
to
6e5a15f
Compare
|
This PR breaks deep includes. |
slonopotamus
force-pushed
the
imagesdir
branch
2 times, most recently
from
d6ebc41
to
e7d0bbb
Compare
…packaging resolves asciidoctor#169 images in tables don't show up resolves asciidoctor#190 plantumlconfig is looking in the wrong dir resolves asciidoctor#30 Inline images are not included
slonopotamus
force-pushed
the
imagesdir
branch
from
e7d0bbb
to
905957c
Compare
|
Okay, this will very likely break some use cases for someone, but overall I believe this is a good change. |
slonopotamus
added a commit
that referenced
this pull request
Feb 4, 2020
We now *do* package inline images, thanks to #283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #169 images in tables don't show up
resolves #30 Inline images are not included