Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #338 rescale color palette to use darker shades of gray #347

Merged
merged 1 commit into from
Jul 18, 2020

Conversation

slonopotamus
Copy link
Contributor

This commit also removes Kindle-specific color adjustments so minor color changes are expected on Kindle

@slonopotamus
Copy link
Contributor Author

@nscheer could you please test this on your Kindle?

@nscheer
Copy link

nscheer commented Jul 8, 2020

@nscheer could you please test this on your Kindle?

Yes, gladly. Is there a specific test document I can build or can you provide one?

@slonopotamus
Copy link
Contributor Author

slonopotamus commented Jul 8, 2020

@nscheer Please, see attached archive with before/after Mobi files of the same sample book:
shades-of-gray.zip
GitHub rejects *.moby attachments for some reason.

…f gray

This commit also removes Kindle-specific color adjustments so minor color changes are expected on Kindle
@slonopotamus
Copy link
Contributor Author

@craigscott-crascit Could you also give this PR a try?

@mojavelinux
Copy link
Member

I know @cexbrayat is also interested in the color palette being one of the ones who originally reported an issue on this topic.

@craigscott-crascit
Copy link

Initial results look good, I'm just waiting on feedback from one other device user.

@nscheer
Copy link

nscheer commented Jul 13, 2020

@nscheer Please, see attached archive with before/after Mobi files of the same sample book:
shades-of-gray.zip
GitHub rejects *.moby attachments for some reason.

Checked both files this morning. On my Kindle Oasis 2020 I'm unable to spot any differences.
Looks good to me!

@slonopotamus
Copy link
Contributor Author

slonopotamus commented Jul 13, 2020

Okay, something has changed.

Before this PR, links (<a>) were specified to have the same color as main text. Now, since we've agreed to no longer specify main text color, I also stopped specifying link color. So they became blue (at least in Calibre).

Uh. I really wish there was a proper CSS rule to distinguish between color and monochrome devices.

@craigscott-crascit
Copy link

Initial results look good, I'm just waiting on feedback from one other device user.

That user has also confirmed it looks a lot better for them now on their device. They had previously provided a side-by-side comparison with other commercially produced content which highlighted the problem, but now the differences in darkness of the fonts are only slight.

@slonopotamus slonopotamus merged commit 3697bd9 into asciidoctor:master Jul 18, 2020
@slonopotamus slonopotamus deleted the shades-of-gray branch July 18, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants