-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves #338 rescale color palette to use darker shades of gray #347
Conversation
@nscheer could you please test this on your Kindle? |
Yes, gladly. Is there a specific test document I can build or can you provide one? |
@nscheer Please, see attached archive with before/after Mobi files of the same sample book: |
…f gray This commit also removes Kindle-specific color adjustments so minor color changes are expected on Kindle
cfa8052
to
9032385
Compare
@craigscott-crascit Could you also give this PR a try? |
I know @cexbrayat is also interested in the color palette being one of the ones who originally reported an issue on this topic. |
Initial results look good, I'm just waiting on feedback from one other device user. |
Checked both files this morning. On my Kindle Oasis 2020 I'm unable to spot any differences. |
Okay, something has changed. Before this PR, links ( Uh. I really wish there was a proper CSS rule to distinguish between color and monochrome devices. |
That user has also confirmed it looks a lot better for them now on their device. They had previously provided a side-by-side comparison with other commercially produced content which highlighted the problem, but now the differences in darkness of the fonts are only slight. |
This commit also removes Kindle-specific color adjustments so minor color changes are expected on Kindle