Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not add revnumber if no project.version #329

Closed
ysb33r opened this issue Apr 7, 2019 · 1 comment
Closed

Do not add revnumber if no project.version #329

ysb33r opened this issue Apr 7, 2019 · 1 comment
Labels
2.x Issue related to the 2.x series bug
Milestone
2.1.0

Comments

@ysb33r
Copy link
Member

ysb33r commented Apr 7, 2019

If project.version is not defined then AbstractAsciidoctorTask.getTaskSpecificDefaultAttributes should not add revnumber as an attribute.
@ysb33r ysb33r added 2.x Issue related to the 2.x series bug labels Apr 7, 2019
@ysb33r ysb33r added this to the 2.0.1 milestone Apr 7, 2019
@ysb33r ysb33r changed the title Do not add revnumber of no project.version Do not add revnumber if no project.version Apr 8, 2019
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Apr 10, 2019
@ysb33r
Conditionally add revnumber and gradle-project-group (asciidoctor#328,a…
eb75b49 
…sciidoctor#329)

- Only add revnumber when project.version is non-null.
- Only add gradle-project-group when project.group is non-null.
ysb33r added a commit that referenced this issue Apr 10, 2019
@ysb33r
Merge pull request #333 from ysb33r/issue-329
ba337db 
Conditionally add revnumber and gradle-project-group (#328,#329)
@ysb33r ysb33r modified the milestones: 2.0.1, 2.1.0 Apr 10, 2019
@ysb33r ysb33r mentioned this issue Apr 11, 2019
Merged
@ysb33r
Copy link
Member Author

ysb33r commented Apr 11, 2019

Scheduled for 2.1.0 release.

lhotari added a commit to lhotari/asciidoctor-gradle-plugin that referenced this issue Jan 24, 2020
@lhotari
Don't add revnumber attr when project.version is unspecified
202e5bf 
- Fixes asciidoctor#329
- project.version defaults to 'unspecified' in Gradle
@lhotari lhotari mentioned this issue Jan 24, 2020
Merged
lhotari added a commit to lhotari/asciidoctor-gradle-plugin that referenced this issue Jan 24, 2020
@lhotari
Don't add revnumber attr when project.version is unspecified
9722677 
- Fixes asciidoctor#329
- project.version defaults to 'unspecified' in Gradle
lhotari added a commit to lhotari/asciidoctor-gradle-plugin that referenced this issue Jan 25, 2020
@lhotari
Don't add revnumber attr when project.version is unspecified
06211bf 
- Fixes asciidoctor#329
- project.version defaults to 'unspecified' in Gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Issue related to the 2.x series bug
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@aalmiray @ysb33r