Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locked PDF does not produce any error #1569

Closed
Vampire opened this issue Mar 13, 2024 · 3 comments
Closed

Locked PDF does not produce any error #1569

Vampire opened this issue Mar 13, 2024 · 3 comments
Labels

Comments

@Vampire
Copy link

Vampire commented Mar 13, 2024

Observed vs. expected behavior

On Windows locked files cannot be overwritten.
The Acrobat Reader locks a PDF file while it is displayed.
So while a PDF is displayed in Acrobat Reader, no PDF-generation tool can update the file.

If you press the "PDF" button in the toolbar, it looks like the PDF gets generated and then the PDF is opened in Acrobat Reader - i.e. brought to front.
But if the PDF was already opened from a previous conversation, the file is simply not changed and you still look at the old version.

It would be great if you would instead get an error message, that the PDF could not be generated / updated.

Steps to reproduce

  • Use Windows
  • Generate the PDF
  • Make sure it is displayed with Acrobat Reader
  • Generate the PDF again

Environment

Plugin Version: 0.41.8

IntelliJ Details: IntelliJ IDEA 2023.3.4 (Ultimate Edition)
Build #IU-233.14475.28, built on February 13, 2024

@Vampire Vampire added the bug label Mar 13, 2024
@ahus1
Copy link
Contributor

ahus1 commented Mar 16, 2024

Thank you for reporting this.

The current version of the plugin shows error messages in the notification tool window.

The next version of the plugin will show a popup window with a descriptive error message. It will also not bring the PDF file into the foreground.

image

I'll update this issue when the next version of the plugin is available.

@Vampire
Copy link
Author

Vampire commented Mar 16, 2024

Ah, now that you say it, I see the notifications.
Thanks for making them more obvious for the future ;-)

@ahus1
Copy link
Contributor

ahus1 commented Mar 23, 2024

This fix is now available as pre-release 0.41.10.

The pre-release of the plugin is available from GitHub releases and the IntelliJ AsciiDoc EAP repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants