Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kroki preview broke since most recent upgrade to 0.41.11 #1585

Closed
kistlin opened this issue Mar 25, 2024 · 4 comments
Closed

Kroki preview broke since most recent upgrade to 0.41.11 #1585

kistlin opened this issue Mar 25, 2024 · 4 comments
Labels

Comments

@kistlin
Copy link

kistlin commented Mar 25, 2024

Observed vs. expected behavior

unable to render AsciiDoc document

org.asciidoctor.jruby.internal.AsciidoctorCoreException: org.jruby.exceptions.NameError: (NameError) asciidoctor: FAILED: /home/user/doc.adoc: Failed to load AsciiDoc document - uninitialized constant AsciidoctorExtensions::KrokiDiagram::Base64

org.jruby.exceptions.NameError: (NameError) asciidoctor: FAILED: /home/user/doc.adoc: Failed to load AsciiDoc document - uninitialized constant AsciidoctorExtensions::KrokiDiagram::Base64

org.jruby.exceptions.NameError: (NameError) uninitialized constant AsciidoctorExtensions::KrokiDiagram::Base64

(the full exception stack trace is available in the IDE's log file. Visit menu item 'Help | Show Log in Explorer' to see the log)

Expected behavior is that the preview is rendered.

Steps to reproduce

Setup this docker compose file to run a local instance.
#1361 (comment)

Configure the plugin to use the local Kroki instance on http://localhost:8000/.
And use the plugin to try and render a mermaid diagram. (same with PlantUML)

Setup a *.adoc with content

[mermaid]
....
sequenceDiagram
    participant Alice
    participant Bob
    Alice->>Bob: Hello Bob, how are you?
    Bob-->>Alice: Great!
....

This used to render, but now fails with the mentioned error.

Environment

Plugin Version: 0.41.11
IntelliJ Details: 2023.3.4

A downgrade to 0.41.9 makes it work again.

@kistlin kistlin added the bug label Mar 25, 2024
@ahus1
Copy link
Contributor

ahus1 commented Mar 26, 2024

Thank you for reporting this, and sorry this causes you trouble. I'll be porting change asciidoctor/asciidoctor-kroki#444 to the AsciiDoc plugin.

BTW, the AsciiDoc plugin for IntelliJ as an embedded Mermaid support which is experimental, still you might want to give it a try. You enable it in the same settings menu where you enabled Kroki.

@ahus1
Copy link
Contributor

ahus1 commented Mar 26, 2024

This will be fixed in the next upcoming release. I'll update the issue once a pre-release is available. Thank you for providing a nice reproducer for the problem.

@ahus1 ahus1 changed the title Preview broke since most recent upgrade to 0.41.11 Kroki preview broke since most recent upgrade to 0.41.11 Mar 27, 2024
@ahus1
Copy link
Contributor

ahus1 commented Mar 27, 2024

There is now release 0.41.12 which includes this change.

I published just now to the JetBrains marketplace. It should be available via the automatic update mechanism later today.

The release of the plugin is available from GitHub releases for manual installation in the meantime.

@kistlin
Copy link
Author

kistlin commented Mar 28, 2024

Thank you for the quick fix. It works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants