-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Darcula theme #21
Comments
Current update:
The preview now uses it's own Darcula CSS, but some of the colors/fonts might not be ideal. Any ideas for improvements welcome. Also, code blocks are a bit tricky, since code blocks seem to use hardcoded coloring (I guess this might be different per source code highlighter, but this is how coderay seems to do it). Like I said, improvements welcome, but IMO, this looks much better than the white preview screen, and is a good step ahead. |
👍 Integrating into the natural environment is a great way for authors to feel "at home". Eventually, we could change the stylesheets based on the user's theme selection.
Simple fix. Just remove the Here's the line that needs to be changed: |
Initial support is in. If you want to propose changes, etc, please make a new issue. |
Really nice start! Darcula!!! 👿 |
Thanks, but as discussed, the code blocks are still an issue, and some of the headers might need some improvement. I'm not a designer however, so... improvements more than welcome :) |
@bodiam Another option is to use highlight.js instead of Coderay and then use one of the themes on this page: https://highlightjs.org/static/demo/. Just set the |
The preview screen uses a template which doesn't take into account the user preferences regarding themes. In effect, this means that the preview window will have a white background, which doesn't look to nice on a Darcula theme.
A custom CSS will be created with some initial support for Darcula.
The text was updated successfully, but these errors were encountered: