Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Spell Checking on more block types #269

Closed
ahus1 opened this issue Jun 7, 2019 · 3 comments
Closed

Enable Spell Checking on more block types #269

ahus1 opened this issue Jun 7, 2019 · 3 comments
Assignees

Comments

@ahus1
Copy link
Contributor

ahus1 commented Jun 7, 2019

Currently spell checking is not supported in comments and some block types.

This is to discuss where spell checking should be enabled in the future:

  • comments
  • sidebar blocks
  • quote blocks

(to be continued)

@ahus1 ahus1 mentioned this issue Jun 7, 2019
@mojavelinux
Copy link
Member

I would start with paragraphs (including special ones), comments, and titles.

If you work at the level of the paragraph, then you don't have to worry about something like a quote block because it's either a paragraph itself or contains paragraphs, so you're already covered. Where writers most likely expect spell checking is in the "prose" (which is what we usually call paragraphs).

@ahus1
Copy link
Contributor Author

ahus1 commented Jun 7, 2019

@mojavelinux - most standard cases are already handled. For IntelliJ I need to tell it on the lexer-token-level what should be spell checked.

Standard paragraphs, title and titles work already. Paragraphs nested inside blocks delimiters don't work yet, some work with the parser will be required there.

@ahus1 ahus1 self-assigned this Jun 7, 2019
@ahus1
Copy link
Contributor Author

ahus1 commented Jun 7, 2019

The pre-release 0.26.17 is now available from Github releases. It adds spell check support for the following tokens:

AsciiDocTokenTypes.LINE_COMMENT,
AsciiDocTokenTypes.BLOCK_COMMENT,
AsciiDocTokenTypes.EXAMPLE_BLOCK,
AsciiDocTokenTypes.SIDEBAR_BLOCK,
AsciiDocTokenTypes.QUOTE_BLOCK,
AsciiDocTokenTypes.LITERAL_BLOCK,
AsciiDocTokenTypes.BLOCKREFTEXT,
AsciiDocTokenTypes.LINKTEXT

I've reviewed the list of the tokens and these where the tokens that were missing. Please comment here if any block still misses spell checking.

@ahus1 ahus1 closed this as completed Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants